Change in osmo-ttcn3-hacks[master]: msc: Fix random error of TC_cl3_rnd_payload

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Thu Jul 26 08:45:27 UTC 2018


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/10166 )

Change subject: msc: Fix random error of TC_cl3_rnd_payload
......................................................................


Patch Set 1: Code-Review+1

(4 comments)

https://gerrit.osmocom.org/#/c/10166/1//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/10166/1//COMMIT_MSG@9
PS1, Line 9: The random length for that test could to out of bounds leading to a
This sentence looks strange to me. Missing word "trigger" or similar after "could"?


https://gerrit.osmocom.org/#/c/10166/1/msc/MSC_Tests.ttcn
File msc/MSC_Tests.ttcn:

https://gerrit.osmocom.org/#/c/10166/1/msc/MSC_Tests.ttcn@1158
PS1, Line 1158: 	// length is limited by PDU_BSSAP length field which includes some
Better use /* */ for comments.


https://gerrit.osmocom.org/#/c/10166/1/msc/MSC_Tests.ttcn@1159
PS1, Line 1159: 	// other fields beside l3info payload. So payl can only be 240 bytes
be "max" 240 bytes?

Why do you use value 241 then? due to accounting the length field too? Would be good to write it down too.


https://gerrit.osmocom.org/#/c/10166/1/msc/MSC_Tests.ttcn@1162
PS1, Line 1162: 	log("Length:", len);
We can drop this line.



-- 
To view, visit https://gerrit.osmocom.org/10166
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7be33e261a11f03a80a6b770b6acf0a4be49b85b
Gerrit-Change-Number: 10166
Gerrit-PatchSet: 1
Gerrit-Owner: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 26 Jul 2018 08:45:27 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180726/32e89c5b/attachment.htm>


More information about the gerrit-log mailing list