Change in libosmocore[master]: logging: log_vty_command_string: Fix undercount of buf alloc size

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Wed Jul 25 08:57:42 UTC 2018


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/10134 )

Change subject: logging: log_vty_command_string: Fix undercount of buf alloc size
......................................................................


Patch Set 1:

Hi Vadim,

indeed this function can be longer improved, since it's clear from this fix that extra bytes are being allocated somewhere else (otherwise it would have failed until now). I wanted to avoid doing more changes which could lead to an error (like decrementing number of allocated bytes) to not mix new bugs with the feature. We can fix your comments in an extra commit later. Thanks for taking the time to investigate.


-- 
To view, visit https://gerrit.osmocom.org/10134
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7aca0ce3d2981001e8081f7cee0dea3e2aaf8f7c
Gerrit-Change-Number: 10134
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Wed, 25 Jul 2018 08:57:42 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180725/3307acc2/attachment.htm>


More information about the gerrit-log mailing list