This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
daniel gerrit-no-reply at lists.osmocom.orgdaniel has posted comments on this change. ( https://gerrit.osmocom.org/10138 ) Change subject: git-version-gen: Don't check for .git directory ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/10138/1/git-version-gen File git-version-gen: https://gerrit.osmocom.org/#/c/10138/1/git-version-gen@a95 PS1, Line 95: > Is .git a symlink in your case? It probably makes sense to still check for existence of .git. Not in the filesystem sense, it is a regular file: daniel at adrastea:~/scm/osmo/onwaves/osmo-sgsn(daniel/onwaves) » cat .git gitdir: /home/daniel/scm/osmo/master/osmo-sgsn/.git/worktrees/osmo-sgsn As I said libosmocore, libosmo-netif, libosmo-abis, osmo-bts, osmo-hlr, .... all don't have this check for .git. We should either add a check everywhere or remove it completely. We could just use a newer git-version-gen like the one from https://github.com/agordon/autotools-scripts/blob/master/config/git-version-gen which uses test "`git log -1 --pretty=format:x . 2>&1`" = x to verify that there is a git repo with a commit. But even without that check git-version-gen reports UNKNOWN if run from a non-git-repo. -- To view, visit https://gerrit.osmocom.org/10138 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sysmon Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I414111b27db9951314e6bc7eff8bc1f10775b3ff Gerrit-Change-Number: 10138 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann at sysmocom.de> Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Comment-Date: Tue, 24 Jul 2018 16:36:51 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180724/b09a3466/attachment.htm>