Change in osmo-bsc[master]: ho cfg: fix unit strings

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Sat Jul 21 17:08:01 UTC 2018


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10057 )

Change subject: ho cfg: fix unit strings
......................................................................

ho cfg: fix unit strings

Change-Id: Ie98a68de207aea69befd24af3f302b6ef9e6f8e4
---
M include/osmocom/bsc/handover_cfg.h
M tests/handover_cfg.vty
2 files changed, 21 insertions(+), 21 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/include/osmocom/bsc/handover_cfg.h b/include/osmocom/bsc/handover_cfg.h
index 2321fcf..865fab9 100644
--- a/include/osmocom/bsc/handover_cfg.h
+++ b/include/osmocom/bsc/handover_cfg.h
@@ -126,8 +126,8 @@
 		"handover1 ", "power budget hysteresis", "<0-999>", atoi, "%u", as_is, \
 		HO_CFG_STR_HANDOVER1 \
 		HO_CFG_STR_POWER_BUDGET \
-		"How many dBm stronger must a neighbor be to become a HO candidate\n" \
-		"Neighbor's strength difference in dBm\n") \
+		"How many dB stronger must a neighbor be to become a HO candidate\n" \
+		"Neighbor's strength difference in dB\n") \
 	\
 	HO_CFG_ONE_MEMBER(unsigned int, hodec1_max_distance, 9999, \
 		"handover1 ", "maximum distance" , "<0-9999>", atoi, "%u", as_is, \
@@ -172,8 +172,8 @@
 		"handover2 ", "power budget hysteresis", "<0-999>", atoi, "%u", as_is, \
 		HO_CFG_STR_HANDOVER2 \
 		HO_CFG_STR_POWER_BUDGET \
-		"How many dBm stronger must a neighbor be to become a HO candidate\n" \
-		"Neighbor's strength difference in dBm\n") \
+		"How many dB stronger must a neighbor be to become a HO candidate\n" \
+		"Neighbor's strength difference in dB\n") \
 	\
 	HO_CFG_ONE_MEMBER(unsigned int, hodec2_max_distance, 9999, \
 		"handover2 ", "maximum distance" , "<0-9999>", atoi, "%u", as_is, \
@@ -208,21 +208,21 @@
 		HO_CFG_STR_HANDOVER2 \
 		HO_CFG_STR_MIN \
 		"How bad may RxQual of an MS become before triggering HO\n" \
-		"minimum RxQual (dBm)\n") \
+		"minimum RxQual\n") \
 	\
 	HO_CFG_ONE_MEMBER(int, hodec2_afs_bias_rxlev, 0, \
 		"handover2 ", "afs-bias rxlev", "<0-20>", atoi, "%d", as_is, \
 		HO_CFG_STR_HANDOVER2 \
 		HO_CFG_STR_AFS_BIAS \
 		"RxLev improvement bias for AFS over other codecs\n" \
-		"Virtual RxLev improvement (dBm)\n") \
+		"Virtual RxLev improvement (dB)\n") \
 	\
 	HO_CFG_ONE_MEMBER(int, hodec2_afs_bias_rxqual, 0, \
 		"handover2 ", "afs-bias rxqual", "<0-7>", atoi, "%d", as_is, \
 		HO_CFG_STR_HANDOVER2 \
 		HO_CFG_STR_AFS_BIAS \
 		"RxQual improvement bias for AFS over other codecs\n" \
-		"Virtual RxQual improvement (dBm)\n") \
+		"Virtual RxQual improvement\n") \
 	\
 	HO_CFG_ONE_MEMBER(int, hodec2_tchf_min_slots, 0, \
 		"handover2 ", "min-free-slots tch/f", "<0-9999>", atoi, "%d", as_is, \
diff --git a/tests/handover_cfg.vty b/tests/handover_cfg.vty
index 3ad44d8..119eaf5 100644
--- a/tests/handover_cfg.vty
+++ b/tests/handover_cfg.vty
@@ -264,14 +264,14 @@
 
 OsmoBSC(config-net)# handover1 power budget ?
   interval    How often to check for a better cell (SACCH frames)
-  hysteresis  How many dBm stronger must a neighbor be to become a HO candidate
+  hysteresis  How many dB stronger must a neighbor be to become a HO candidate
 
 OsmoBSC(config-net)# handover1 power budget interval ?
   <1-99>   Check for stronger neighbor every N number of SACCH frames
   default  Use default (6), remove explicit setting on this node
 
 OsmoBSC(config-net)# handover1 power budget hysteresis ?
-  <0-999>  Neighbor's strength difference in dBm
+  <0-999>  Neighbor's strength difference in dB
   default  Use default (3), remove explicit setting on this node
 
 OsmoBSC(config-net)# handover1 maximum ?
@@ -312,14 +312,14 @@
 
 OsmoBSC(config-net)# handover2 power budget ?
   interval    How often to check for a better cell (SACCH frames)
-  hysteresis  How many dBm stronger must a neighbor be to become a HO candidate
+  hysteresis  How many dB stronger must a neighbor be to become a HO candidate
 
 OsmoBSC(config-net)# handover2 power budget interval ?
   <1-99>   Check for stronger neighbor every N number of SACCH frames
   default  Use default (6), remove explicit setting on this node
 
 OsmoBSC(config-net)# handover2 power budget hysteresis ?
-  <0-999>  Neighbor's strength difference in dBm
+  <0-999>  Neighbor's strength difference in dB
   default  Use default (3), remove explicit setting on this node
 
 OsmoBSC(config-net)# handover2 maximum ?
@@ -348,7 +348,7 @@
   default     Use default (-100), remove explicit setting on this node
 
 OsmoBSC(config-net)# handover2 min rxqual ?
-  <0-7>    minimum RxQual (dBm)
+  <0-7>    minimum RxQual
   default  Use default (5), remove explicit setting on this node
 
 OsmoBSC(config-net)# handover2 afs-bias ?
@@ -356,11 +356,11 @@
   rxqual  RxQual improvement bias for AFS over other codecs
 
 OsmoBSC(config-net)# handover2 afs-bias rxlev ?
-  <0-20>   Virtual RxLev improvement (dBm)
+  <0-20>   Virtual RxLev improvement (dB)
   default  Use default (0), remove explicit setting on this node
 
 OsmoBSC(config-net)# handover2 afs-bias rxqual ?
-  <0-7>    Virtual RxQual improvement (dBm)
+  <0-7>    Virtual RxQual improvement
   default  Use default (0), remove explicit setting on this node
 
 OsmoBSC(config-net)# handover2 min-free-slots ?
@@ -482,14 +482,14 @@
 
 OsmoBSC(config-net-bts)# handover1 power budget ?
   interval    How often to check for a better cell (SACCH frames)
-  hysteresis  How many dBm stronger must a neighbor be to become a HO candidate
+  hysteresis  How many dB stronger must a neighbor be to become a HO candidate
 
 OsmoBSC(config-net-bts)# handover1 power budget interval ?
   <1-99>   Check for stronger neighbor every N number of SACCH frames
   default  Use default (6), remove explicit setting on this node
 
 OsmoBSC(config-net-bts)# handover1 power budget hysteresis ?
-  <0-999>  Neighbor's strength difference in dBm
+  <0-999>  Neighbor's strength difference in dB
   default  Use default (3), remove explicit setting on this node
 
 OsmoBSC(config-net-bts)# handover1 maximum ?
@@ -530,14 +530,14 @@
 
 OsmoBSC(config-net-bts)# handover2 power budget ?
   interval    How often to check for a better cell (SACCH frames)
-  hysteresis  How many dBm stronger must a neighbor be to become a HO candidate
+  hysteresis  How many dB stronger must a neighbor be to become a HO candidate
 
 OsmoBSC(config-net-bts)# handover2 power budget interval ?
   <1-99>   Check for stronger neighbor every N number of SACCH frames
   default  Use default (6), remove explicit setting on this node
 
 OsmoBSC(config-net-bts)# handover2 power budget hysteresis ?
-  <0-999>  Neighbor's strength difference in dBm
+  <0-999>  Neighbor's strength difference in dB
   default  Use default (3), remove explicit setting on this node
 
 OsmoBSC(config-net-bts)# handover2 maximum ?
@@ -566,7 +566,7 @@
   default     Use default (-100), remove explicit setting on this node
 
 OsmoBSC(config-net-bts)# handover2 min rxqual ?
-  <0-7>    minimum RxQual (dBm)
+  <0-7>    minimum RxQual
   default  Use default (5), remove explicit setting on this node
 
 OsmoBSC(config-net-bts)# handover2 afs-bias ?
@@ -574,11 +574,11 @@
   rxqual  RxQual improvement bias for AFS over other codecs
 
 OsmoBSC(config-net-bts)# handover2 afs-bias rxlev ?
-  <0-20>   Virtual RxLev improvement (dBm)
+  <0-20>   Virtual RxLev improvement (dB)
   default  Use default (0), remove explicit setting on this node
 
 OsmoBSC(config-net-bts)# handover2 afs-bias rxqual ?
-  <0-7>    Virtual RxQual improvement (dBm)
+  <0-7>    Virtual RxQual improvement
   default  Use default (0), remove explicit setting on this node
 
 OsmoBSC(config-net-bts)# handover2 min-free-slots ?

-- 
To view, visit https://gerrit.osmocom.org/10057
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie98a68de207aea69befd24af3f302b6ef9e6f8e4
Gerrit-Change-Number: 10057
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180721/d7adef3e/attachment.htm>


More information about the gerrit-log mailing list