Change in osmo-bsc[master]: lcls: do not LCLS call legs with different codecs

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri Jul 20 04:55:30 UTC 2018


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9940 )

Change subject: lcls: do not LCLS call legs with different codecs
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

looks good to me but we need to save the VTY setting.

https://gerrit.osmocom.org/#/c/9940/1/src/osmo-bsc/osmo_bsc_vty.c
File src/osmo-bsc/osmo_bsc_vty.c:

https://gerrit.osmocom.org/#/c/9940/1/src/osmo-bsc/osmo_bsc_vty.c@655
PS1, Line 655:       "lcls-codec-mismatch (allowed|forbidden)",
you're not saving this VTY setting during config_write to the file. Let's add that missing part.



-- 
To view, visit https://gerrit.osmocom.org/9940
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I157549129a40c64364dc126f67195759e5f1d60f
Gerrit-Change-Number: 9940
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Fri, 20 Jul 2018 04:55:30 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180720/c92ff7cc/attachment.htm>


More information about the gerrit-log mailing list