Change in libosmocore[master]: utils_test: check stderr to catch sanitizer issues

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Thu Jul 19 20:16:31 UTC 2018


Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/10067


Change subject: utils_test: check stderr to catch sanitizer issues
......................................................................

utils_test: check stderr to catch sanitizer issues

Recent OS#3407 shows that we should verify stderr to catch sanitizer failures.
(They might not always be ignorable like that one.)

Change-Id: Ic9e437a1cc96ae081e0fd6a9b6e3156987e14c0c
---
M tests/Makefile.am
M tests/testsuite.at
A tests/utils/utils_test.err
3 files changed, 3 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/67/10067/1

diff --git a/tests/Makefile.am b/tests/Makefile.am
index db4e520..7d7902c 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -240,7 +240,7 @@
 	     vty/ok_tabs_and_spaces.cfg \
 	     vty/ok_tabs.cfg \
 	     comp128/comp128_test.ok bits/bitfield_test.ok		\
-	     utils/utils_test.ok stats/stats_test.ok			\
+	     utils/utils_test.ok utils_test.err stats/stats_test.ok	\
 	     bitvec/bitvec_test.ok msgb/msgb_test.ok bits/bitcomp_test.ok \
 	     sim/sim_test.ok tlv/tlv_test.ok abis/abis_test.ok		\
 	     gsup/gsup_test.ok gsup/gsup_test.err			\
diff --git a/tests/testsuite.at b/tests/testsuite.at
index 15a89b6..43b58e8 100644
--- a/tests/testsuite.at
+++ b/tests/testsuite.at
@@ -205,7 +205,8 @@
 AT_SETUP([utils])
 AT_KEYWORDS([utils])
 cat $abs_srcdir/utils/utils_test.ok > expout
-AT_CHECK([$abs_top_builddir/tests/utils/utils_test], [0], [expout], [ignore])
+cat $abs_srcdir/utils/utils_test.err > experr
+AT_CHECK([$abs_top_builddir/tests/utils/utils_test], [0], [expout], [experr])
 AT_CLEANUP
 
 AT_SETUP([stats])
diff --git a/tests/utils/utils_test.err b/tests/utils/utils_test.err
new file mode 100644
index 0000000..e69de29
--- /dev/null
+++ b/tests/utils/utils_test.err

-- 
To view, visit https://gerrit.osmocom.org/10067
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic9e437a1cc96ae081e0fd6a9b6e3156987e14c0c
Gerrit-Change-Number: 10067
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180719/96e3a144/attachment.htm>


More information about the gerrit-log mailing list