Change in osmo-ttcn3-hacks[master]: fix TC_pdp4_act_deact_with_separate_dns

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Stefan Sperling gerrit-no-reply at lists.osmocom.org
Thu Jul 19 17:26:10 UTC 2018


Stefan Sperling has uploaded this change for review. ( https://gerrit.osmocom.org/10060


Change subject: fix TC_pdp4_act_deact_with_separate_dns
......................................................................

fix TC_pdp4_act_deact_with_separate_dns

Do not delete the PDP context too early, and look for the second DNS
server in the correct place (2nd match on IPCP protocol, not 1st).

Change-Id: I109491cc9ccb060792e29bf6b2999ef48723edbf
Related: OS#3319
---
M ggsn_tests/GGSN_Tests.ttcn
1 file changed, 1 insertion(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/60/10060/1

diff --git a/ggsn_tests/GGSN_Tests.ttcn b/ggsn_tests/GGSN_Tests.ttcn
index 6ae205f..5673a99 100644
--- a/ggsn_tests/GGSN_Tests.ttcn
+++ b/ggsn_tests/GGSN_Tests.ttcn
@@ -1017,11 +1017,10 @@
 		if (not match(pco_neg_dns, pco_neg_dns_expected)) {
 			setverdict(fail, "Primary DNS IPv4 PCO option not found");
 		}
-		f_pdp_ctx_del(ctx, '1'B);
 
 		/* Check if secondary DNS is contained */
 		/* Note: this check fill fail due to a bug in osmo-ggsn, see also OS#3381 */
-		pco_neg_dns := f_PCO_extract_proto(ctx.pco_neg, '8021'O, 1);
+		pco_neg_dns := f_PCO_extract_proto(ctx.pco_neg, '8021'O, 2);
 		pco_neg_dns_expected := '0200000A8306'O & ggsn_ip4_dns2
 		if (not match(pco_neg_dns, pco_neg_dns_expected)) {
 			setverdict(fail, "Secondary DNS IPv4 PCO option not found");

-- 
To view, visit https://gerrit.osmocom.org/10060
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I109491cc9ccb060792e29bf6b2999ef48723edbf
Gerrit-Change-Number: 10060
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180719/2a0061b8/attachment.htm>


More information about the gerrit-log mailing list