Change in osmo-bts[master]: l1sap: add_l1sap_header: Compact msgb_push ret assignment

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Thu Jul 19 15:05:31 UTC 2018


Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/10052


Change subject: l1sap: add_l1sap_header: Compact msgb_push ret assignment
......................................................................

l1sap: add_l1sap_header: Compact msgb_push ret assignment

Change-Id: Ia427c216cd096d313b234ca244eb71837450e2a9
---
M src/common/l1sap.c
1 file changed, 1 insertion(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/52/10052/1

diff --git a/src/common/l1sap.c b/src/common/l1sap.c
index 3a40949..8936674 100644
--- a/src/common/l1sap.c
+++ b/src/common/l1sap.c
@@ -139,8 +139,7 @@
 	     gsm_lchan_name(lchan), osmo_hexdump(rmsg->data, rmsg->len));
 
 	rmsg->l2h = rmsg->data;
-	msgb_push(rmsg, sizeof(*l1sap));
-	rmsg->l1h = rmsg->data;
+	rmsg->l1h = msgb_push(rmsg, sizeof(*l1sap));
 	l1sap = msgb_l1sap_prim(rmsg);
 	osmo_prim_init(&l1sap->oph, SAP_GSM_PH, PRIM_TCH, PRIM_OP_INDICATION,
 		       rmsg);

-- 
To view, visit https://gerrit.osmocom.org/10052
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia427c216cd096d313b234ca244eb71837450e2a9
Gerrit-Change-Number: 10052
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180719/f31070c3/attachment.htm>


More information about the gerrit-log mailing list