This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Pau Espin Pedrol gerrit-no-reply at lists.osmocom.orgPau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/9930 ) Change subject: build: fix packaging problems and make distcheck happy ...................................................................... Patch Set 1: (4 comments) No fight today, fine for me :-) Maybe only check the new comment I added about clean-local vs distclean-local. https://gerrit.osmocom.org/#/c/9930/1/libgsmhr/Makefile.am File libgsmhr/Makefile.am: https://gerrit.osmocom.org/#/c/9930/1/libgsmhr/Makefile.am@15 PS1, Line 15: $(srcdir)/fetch_sources.py "${REFSRC_PATH}" > Hmm, in libosmocore we use exactly 'srcdir'... […] I would not use *_PYTHON stuff as that seems more related to python stuff you want to install and not use at build time. Fine to keep srcdir if it works. https://gerrit.osmocom.org/#/c/9930/1/libgsmhr/Makefile.am@31 PS1, Line 31: -rm -rf ${REFSRC_PATH}/ Why is distclean-local different than clean-local? https://gerrit.osmocom.org/#/c/9930/1/tests/Makefile.am File tests/Makefile.am: https://gerrit.osmocom.org/#/c/9930/1/tests/Makefile.am@82 PS1, Line 82: ref-files \ > For some reason, having 'dir/' breaks the build... […] Ugh, ok, no idea. https://gerrit.osmocom.org/#/c/9930/1/tests/testsuite.at File tests/testsuite.at: https://gerrit.osmocom.org/#/c/9930/1/tests/testsuite.at@15 PS1, Line 15: $abs_srcdir/io/io_sample.txt], > There is EXTRA_DIST definition in tests/Makefile.am. Ah too bad sorry, I confused this file with the makefile.am one :) -- To view, visit https://gerrit.osmocom.org/9930 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: gapk Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieb8f6a2a81f9b75c8c6c5db443b0e7be02bc4153 Gerrit-Change-Number: 9930 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-CC: Harald Welte <laforge at gnumonks.org> Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Comment-Date: Mon, 16 Jul 2018 18:34:10 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180716/9004ef28/attachment.htm>