Change in osmo-ttcn3-hacks[master]: sgsn: Fix TC_attach_pdp_act_user_deact_mt

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Mon Jul 16 17:46:19 UTC 2018


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10007 )

Change subject: sgsn: Fix TC_attach_pdp_act_user_deact_mt
......................................................................

sgsn: Fix TC_attach_pdp_act_user_deact_mt

Expect to receive a TearDown Indicator.

Change-Id: I37dafb5e93ac06b3bd9cab2c06aa3735a8429f2f
---
M sgsn/SGSN_Tests.ttcn
M sgsn/expected-results.xml
2 files changed, 3 insertions(+), 8 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn
index e76ed09..214239e 100644
--- a/sgsn/SGSN_Tests.ttcn
+++ b/sgsn/SGSN_Tests.ttcn
@@ -962,7 +962,7 @@
 	GTP.send(ts_GTPC_DeletePDP(peer, seq_nr, apars.sgsn_tei_c, apars.nsapi, '1'B));
 
 	interleave {
-	[] BSSGP.receive(tr_BD_L3_MT(tr_SM_DEACT_PDP_REQ_MT(apars.tid, ?))) {
+	[] BSSGP.receive(tr_BD_L3_MT(tr_SM_DEACT_PDP_REQ_MT(apars.tid, ?, true))) {
 		BSSGP.send(ts_SM_DEACT_PDP_ACCEPT_MO(apars.tid));
 		}
 	[] GTP.receive(tr_GTPC_MsgType(?, deletePDPContextResponse, apars.ggsn_tei_c)) { }
diff --git a/sgsn/expected-results.xml b/sgsn/expected-results.xml
index f2f2500..2d7063b 100644
--- a/sgsn/expected-results.xml
+++ b/sgsn/expected-results.xml
@@ -1,5 +1,5 @@
 <?xml version="1.0"?>
-<testsuite name='Titan' tests='26' failures='5' errors='3' skipped='0' inconc='0' time='MASKED'>
+<testsuite name='Titan' tests='27' failures='4' errors='3' skipped='0' inconc='0' time='MASKED'>
   <testcase classname='SGSN_Tests' name='TC_attach' time='MASKED'/>
   <testcase classname='SGSN_Tests' name='TC_attach_mnc3' time='MASKED'/>
   <testcase classname='SGSN_Tests' name='TC_attach_umts_aka_umts_res' time='MASKED'/>
@@ -56,12 +56,7 @@
   <testcase classname='SGSN_Tests' name='TC_attach_pdp_act_user' time='MASKED'/>
   <testcase classname='SGSN_Tests' name='TC_attach_pdp_act_ggsn_reject' time='MASKED'/>
   <testcase classname='SGSN_Tests' name='TC_attach_pdp_act_user_deact_mo' time='MASKED'/>
-  <testcase classname='SGSN_Tests' name='TC_attach_pdp_act_user_deact_mt' time='MASKED'>
-    <failure type='fail-verdict'>Tguard timeout
-      SGSN_Tests.ttcn:MASKED SGSN_Tests control part
-      SGSN_Tests.ttcn:MASKED TC_attach_pdp_act_user_deact_mt testcase
-    </failure>
-  </testcase>
+  <testcase classname='SGSN_Tests' name='TC_attach_pdp_act_user_deact_mt' time='MASKED'/>
   <testcase classname='SGSN_Tests' name='TC_attach_second_attempt' time='MASKED'>
     <error type='DTE'></error>
   </testcase>

-- 
To view, visit https://gerrit.osmocom.org/10007
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I37dafb5e93ac06b3bd9cab2c06aa3735a8429f2f
Gerrit-Change-Number: 10007
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180716/0bde2928/attachment.htm>


More information about the gerrit-log mailing list