Change in osmo-sgsn[master]: sgsn: Don't attempt to delete GTP pdp ctx if GGSN was restarted

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Mon Jul 16 08:14:10 UTC 2018


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/9993 )

Change subject: sgsn: Don't attempt to delete GTP pdp ctx if GGSN was restarted
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/9993/1//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/9993/1//COMMIT_MSG@20
PS1, Line 20: when
> What happens if the MS doesn't respond?
When the PDP CTX DEACT is sent to the MS (gsm48_tx_gsm_deact_pdp_req), timer 3395 is armed.

The first 4 times the timer fires, a retrans is sent (pdpctx_timer_cb). 5th time, sgsn_delete_pdp_ctx() is called, which will attempt to send a DEACT REQ towards the GGSN but not free the ctx if ggsn is not available.

So indeed I think we need to check in the 5th time code path if ggsn is available or not and then free if not available. Good point there.



-- 
To view, visit https://gerrit.osmocom.org/9993
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c74098e181552c218e152bf4ac5035cea770428
Gerrit-Change-Number: 9993
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-CC: Holger Freyther <holger at freyther.de>
Gerrit-Comment-Date: Mon, 16 Jul 2018 08:14:10 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180716/e41d0b91/attachment.htm>


More information about the gerrit-log mailing list