Change in pysim[master]: pySim-read: Print exception when reading of EF.MSISDN fails

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Fri Jul 13 08:56:58 UTC 2018


dexter has submitted this change and it was merged. ( https://gerrit.osmocom.org/9968 )

Change subject: pySim-read: Print exception when reading of EF.MSISDN fails
......................................................................

pySim-read: Print exception when reading of EF.MSISDN fails

At the moment the exception is catched, but there is only a vague
error message printed. However, the exception string usually tells
us the status word, so it is very valuable to see it. Lets make
sure that the exception string is printed here.

Change-Id: Icb30470b1c0eee6a15fc028da820e92bf9ded27a
---
M pySim-read.py
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  dexter: Verified



diff --git a/pySim-read.py b/pySim-read.py
index 5ca39ee..f55b256 100755
--- a/pySim-read.py
+++ b/pySim-read.py
@@ -134,8 +134,8 @@
 				print("MSISDN: Not available")
 		else:
 			print("MSISDN: Can't read, response code = %s" % (sw,))
-	except:
-		print "MSISDN: Can't read. Probably not existing file"
+	except Exception as e:
+		print "MSISDN: Can't read file -- " + str(e)
 
 	# Done for this card and maybe for everything ?
 	print "Done !\n"

-- 
To view, visit https://gerrit.osmocom.org/9968
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Icb30470b1c0eee6a15fc028da820e92bf9ded27a
Gerrit-Change-Number: 9968
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180713/1f5623cc/attachment.htm>


More information about the gerrit-log mailing list