This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9978 ) Change subject: ctrl: Introduce ctrl_cmd_parse3 API ...................................................................... Patch Set 2: I'm not sure if the API shouldn't be redesigned completely. The entire idea of returning an ERROR cmd on a parse error seems like it's mixing two independent tasks: parsing the message + generating an error message on parser error. I think a clean API would separate those two, e.g. by returning an parser error code (as integer), which then can be used by another function to generate an error message, if so desired. What do you think? -- To view, visit https://gerrit.osmocom.org/9978 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide9170e5c31967c353f8fe4e8227e64130b91eae Gerrit-Change-Number: 9978 Gerrit-PatchSet: 2 Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: Harald Welte <laforge at gnumonks.org> Gerrit-Comment-Date: Fri, 13 Jul 2018 05:06:03 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180713/5efaf89e/attachment.htm>