This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgNeels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/9973 ) Change subject: nat: ctrl: Use ctrl_cmd_parse2 to obtain detailed error ...................................................................... Patch Set 1: -Code-Review (1 comment) https://gerrit.osmocom.org/#/c/9973/1/openbsc/src/osmo-bsc_nat/bsc_nat_ctrl.c File openbsc/src/osmo-bsc_nat/bsc_nat_ctrl.c: https://gerrit.osmocom.org/#/c/9973/1/openbsc/src/osmo-bsc_nat/bsc_nat_ctrl.c@106 PS1, Line 106: cmd = ctrl_cmd_parse2(bsc, msg); so below, we send the cmd out again, shouldn't this then use ctrl_cmd_parse3() and not send cmds that failed to parse? -- To view, visit https://gerrit.osmocom.org/9973 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6ef2b6e309632ed9cb296e8a1e71f879007a36ae Gerrit-Change-Number: 9973 Gerrit-PatchSet: 1 Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Comment-Date: Thu, 12 Jul 2018 18:22:24 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180712/fd4eeb58/attachment.htm>