This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgNeels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/9979 ) Change subject: nat: ctrl: use strtol instead of atoi as it has explicit error documentation ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/9979/1/openbsc/src/osmo-bsc_nat/bsc_nat_ctrl.c File openbsc/src/osmo-bsc_nat/bsc_nat_ctrl.c: https://gerrit.osmocom.org/#/c/9979/1/openbsc/src/osmo-bsc_nat/bsc_nat_ctrl.c@89 PS1, Line 89: int id = (long int) strtol(id_str, &endptr, 10); according to my man, strol() returns long int. What's the point of the cast? particularly when it gets assigned to int right after that? I thought the point of using strol() is to check errno afterwards? -- To view, visit https://gerrit.osmocom.org/9979 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ief0b203efbcf2be04253b5056840be94d58a9994 Gerrit-Change-Number: 9979 Gerrit-PatchSet: 1 Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Comment-Date: Thu, 12 Jul 2018 18:13:25 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180712/5787a642/attachment.htm>