Change in libosmocore[master]: vty: fix use-after-free and memleaks in is_cmd_ambiguous()

[Neels Hofmeyr]

Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/9939 )

Change subject: vty: fix use-after-free and memleaks in is_cmd_ambiguous()
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.osmocom.org/#/c/9939/2//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/9939/2//COMMIT_MSG@13
PS2, Line 13: Add cmd_deopt_with_ctx() to allow passing a specific talloc ctx.
> Since we decided to modify the existing cmd_deopt(), […]
meh, sorry about that. svn would have allowed me to fix the log message without a force-push :)


https://gerrit.osmocom.org/#/c/9939/2/tests/vty/vty_test.c
File tests/vty/vty_test.c:

https://gerrit.osmocom.org/#/c/9939/2/tests/vty/vty_test.c@402
PS2, Line 402: 	printf("Called: 'ambiguous_nr <0-23> keyword'\n");
> Would be great to have the '(argc=%d)' debug here too.
doesn't apply, the argc is *always* 1 here. It's only in above cmd where the argc may be 0 or 1 due to the optional arg



-- 
To view, visit https://gerrit.osmocom.org/9939
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia71ba742108b5ff020997bfb612ad5eb30d04fcd
Gerrit-Change-Number: 9939
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-CC: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Thu, 12 Jul 2018 13:11:29 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180712/9bdf1e6b/attachment.htm>