Change in libosmo-sccp[master]: fix memleak in ipa_rx_msg_sccp

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Wed Jul 11 00:36:04 UTC 2018


Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/9951


Change subject: fix memleak in ipa_rx_msg_sccp
......................................................................

fix memleak in ipa_rx_msg_sccp

After m3ua_xfer_from_data() has copied the msgb data, we need to free the msgb.

Change-Id: I2263751c0aa3ae32455847c7622af8be0a1e7802
---
M src/ipa.c
1 file changed, 1 insertion(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/51/9951/1

diff --git a/src/ipa.c b/src/ipa.c
index 0e6f683..e15b1d8 100644
--- a/src/ipa.c
+++ b/src/ipa.c
@@ -258,6 +258,7 @@
 	data_hdr.dpc = osmo_htonl(dpc);
 	/* Create M3UA message in XUA structure */
 	xua = m3ua_xfer_from_data(&data_hdr, msgb_l2(msg), msgb_l2len(msg));
+	msgb_free(msg);
 	/* Update xua->mtp with values from data_hdr */
 	m3ua_dh_to_xfer_param(&xua->mtp, &data_hdr);
 

-- 
To view, visit https://gerrit.osmocom.org/9951
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2263751c0aa3ae32455847c7622af8be0a1e7802
Gerrit-Change-Number: 9951
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180711/8482404f/attachment.htm>


More information about the gerrit-log mailing list