This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Vadim Yanitskiy gerrit-no-reply at lists.osmocom.orgVadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/9930 )
Change subject: build: fix packaging problems and make distcheck happy
......................................................................
Patch Set 1:
(3 comments)
https://gerrit.osmocom.org/#/c/9930/1/libgsmhr/Makefile.am
File libgsmhr/Makefile.am:
https://gerrit.osmocom.org/#/c/9930/1/libgsmhr/Makefile.am@15
PS1, Line 15: $(srcdir)/fetch_sources.py "${REFSRC_PATH}"
> Since this is in EXTRA_DIST I bet this should be $(builddir) instead of srcdir.
Hmm, in libosmocore we use exactly 'srcdir'...
I don't think it makes sense in context of this change.
After reading https://www.gnu.org/software/automake/manual/html_node/Python.html I am wondering, may we use noinst_PYTHON or nodist_python_PYTHON for this script?
https://gerrit.osmocom.org/#/c/9930/1/tests/Makefile.am
File tests/Makefile.am:
https://gerrit.osmocom.org/#/c/9930/1/tests/Makefile.am@82
PS1, Line 82: ref-files \
> If it's a directory I'd be more easy to follow if you add a "/" at the end.
For some reason, having 'dir/' breaks the build...
I noticed that this results in embedding this directory, i.e.:
expected: tests/ref-files/...
got: tests/ref-files/ref-files/...
https://gerrit.osmocom.org/#/c/9930/1/tests/testsuite.at
File tests/testsuite.at:
https://gerrit.osmocom.org/#/c/9930/1/tests/testsuite.at@15
PS1, Line 15: $abs_srcdir/io/io_sample.txt],
> I think we are missing EXTRA_DIT and adding those there, like we do in all other projects with . […]
There is EXTRA_DIST definition in tests/Makefile.am.
--
To view, visit https://gerrit.osmocom.org/9930
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: gapk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb8f6a2a81f9b75c8c6c5db443b0e7be02bc4153
Gerrit-Change-Number: 9930
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 09 Jul 2018 17:52:54 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180709/2f4387a5/attachment.htm>