Change in osmocom-bb[master]: Move from libc random() to osmo_get_rand_id

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Holger Freyther gerrit-no-reply at lists.osmocom.org
Sat Jul 7 23:54:04 UTC 2018


Holger Freyther has posted comments on this change. ( https://gerrit.osmocom.org/9914 )

Change subject: Move from libc random() to osmo_get_rand_id
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/9914/1/src/host/layer23/src/mobile/gsm322.c
File src/host/layer23/src/mobile/gsm322.c:

https://gerrit.osmocom.org/#/c/9914/1/src/host/layer23/src/mobile/gsm322.c@964
PS1, Line 964: 		move = move % entries;
> cosmetic: this line may go under the 'else' part of condition.
it should have read: "move = random()"; because we will execute % random anyway. I will update it.



-- 
To view, visit https://gerrit.osmocom.org/9914
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0cc64663cd4b90c027b79545dc5d3ac9d87b9dd
Gerrit-Change-Number: 9914
Gerrit-PatchSet: 1
Gerrit-Owner: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Sat, 07 Jul 2018 23:54:04 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180707/c1eb0201/attachment.htm>


More information about the gerrit-log mailing list