This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9911 ) Change subject: UART: remove unused code ...................................................................... UART: remove unused code PutChar already takes care of enabling the IRQ Change-Id: I63af5eba27c9a6f3e23412060028e817e4d9f233 --- M firmware/libboard/common/source/uart_console.c 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified Harald Welte: Looks good to me, approved diff --git a/firmware/libboard/common/source/uart_console.c b/firmware/libboard/common/source/uart_console.c index 9004197..07f41ed 100644 --- a/firmware/libboard/common/source/uart_console.c +++ b/firmware/libboard/common/source/uart_console.c @@ -125,7 +125,6 @@ Uart *uart = CONSOLE_UART; if (uart->UART_SR & UART_SR_TXRDY) { if (!rbuf_is_empty(&uart_tx_buffer)) { - //uart->UART_IER = UART_IER_TXRDY; uart->UART_THR = rbuf_read(&uart_tx_buffer); } else { uart->UART_IDR = UART_IER_TXRDY; -- To view, visit https://gerrit.osmocom.org/9911 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I63af5eba27c9a6f3e23412060028e817e4d9f233 Gerrit-Change-Number: 9911 Gerrit-PatchSet: 1 Gerrit-Owner: Kévin Redon <kredon at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180707/abbaf56f/attachment.htm>