Change in openbsc[master]: bsc-nat: forward_sccp_to_msc: Fix memleak on receive from non authent...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Holger Freyther gerrit-no-reply at lists.osmocom.org
Sat Jul 7 13:45:21 UTC 2018


Holger Freyther has posted comments on this change. ( https://gerrit.osmocom.org/9509 )

Change subject: bsc-nat: forward_sccp_to_msc: Fix memleak on receive from non authenticated bsc
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/9509/1/openbsc/src/osmo-bsc_nat/bsc_nat.c
File openbsc/src/osmo-bsc_nat/bsc_nat.c:

https://gerrit.osmocom.org/#/c/9509/1/openbsc/src/osmo-bsc_nat/bsc_nat.c@a1127
PS1, Line 1127: 
Are you sure this leaked? The code relied on the parent/child relationship of a talloc context. "parsed" is allocated in the "msg" context. It's still better to explicitly free it.



-- 
To view, visit https://gerrit.osmocom.org/9509
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd0c145ff733fdfb2f6fcb32065de99ee951d106
Gerrit-Change-Number: 9509
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: Holger Freyther <holger at freyther.de>
Gerrit-Comment-Date: Sat, 07 Jul 2018 13:45:21 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180707/f6149dee/attachment.htm>


More information about the gerrit-log mailing list