This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9887 ) Change subject: fix LED switching on/off ...................................................................... fix LED switching on/off In the SIMtrace and QMOD schematics the LEDs are connected to +3.3V. Thus to switch the LED on we need to set the pin low. Change-Id: Id8cc27e6f0b6556ba5e7ea4d254dd0fe59042a0c --- M firmware/libboard/common/source/led.c 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified Harald Welte: Looks good to me, approved diff --git a/firmware/libboard/common/source/led.c b/firmware/libboard/common/source/led.c index 540f031..00082e2 100644 --- a/firmware/libboard/common/source/led.c +++ b/firmware/libboard/common/source/led.c @@ -16,9 +16,9 @@ ASSERT(led < PIO_LISTSIZE(pinsLeds)); if (on) - PIO_Set(&pinsLeds[led]); - else PIO_Clear(&pinsLeds[led]); + else + PIO_Set(&pinsLeds[led]); } /* LED blinking code */ -- To view, visit https://gerrit.osmocom.org/9887 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Id8cc27e6f0b6556ba5e7ea4d254dd0fe59042a0c Gerrit-Change-Number: 9887 Gerrit-PatchSet: 5 Gerrit-Owner: Kévin Redon <kredon at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180704/5009de05/attachment.htm>