This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Kévin Redon gerrit-no-reply at lists.osmocom.orgKévin Redon has posted comments on this change. ( https://gerrit.osmocom.org/9863 ) Change subject: update_fidi: remove debug output since this function is called in time critical ISR ...................................................................... Patch Set 4: > is this really needed? particularly now that the console is going > through the ringbuffer and is not busy-waiting? Can we print the > message at a later point after we left IRQ context? the message is printed in sniffer.c just before using update_fidi (at the end of the PPS procedure). I still would avoid any printf since it is still used in an ISR (only after a SIM RST though). I don't mind leaving the messages, but then the reset handling should be placed outside the ISR (which is fine with me, since resets are quit long usually). as you prefer -- To view, visit https://gerrit.osmocom.org/9863 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I08f407d407a18dae3f360ddc64769ddfaeb5b559 Gerrit-Change-Number: 9863 Gerrit-PatchSet: 4 Gerrit-Owner: Kévin Redon <kredon at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Kévin Redon <kredon at sysmocom.de> Gerrit-CC: Harald Welte <laforge at gnumonks.org> Gerrit-Comment-Date: Wed, 04 Jul 2018 14:03:30 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180704/72afe6fa/attachment.htm>