Change in simtrace2[master]: ISO7816: change update_fidi to use provided USART

[Kévin Redon]

Kévin Redon has posted comments on this change. ( https://gerrit.osmocom.org/9853 )

Change subject: ISO7816: change update_fidi to use provided USART
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/9853/1/firmware/libcommon/source/simtrace_iso7816.c
File firmware/libcommon/source/simtrace_iso7816.c:

https://gerrit.osmocom.org/#/c/9853/1/firmware/libcommon/source/simtrace_iso7816.c@138
PS1, Line 138: 		TRACE_INFO("updated USART Fi(%u)/Di(%u) ratio(%d): %u\n\r", fi, di, ratio, usart->US_FIDI);
> it would make sense to print the UASRT number as otherwise you don't know if a given TRACE/log messa […]
fixed in newer patchset



-- 
To view, visit https://gerrit.osmocom.org/9853
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I716f4bc3a22800cbce402b146f14ef8b2aab2a98
Gerrit-Change-Number: 9853
Gerrit-PatchSet: 1
Gerrit-Owner: Kévin Redon <kredon at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Kévin Redon <kredon at sysmocom.de>
Gerrit-Comment-Date: Wed, 04 Jul 2018 13:45:22 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180704/30e3f30e/attachment.htm>