This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Kévin Redon gerrit-no-reply at lists.osmocom.orgKévin Redon has posted comments on this change. ( https://gerrit.osmocom.org/9873 ) Change subject: sniffer USB: implement USB communication and send parsed messages ...................................................................... Patch Set 6: (1 comment) https://gerrit.osmocom.org/#/c/9873/5/firmware/libcommon/source/sniffer.c File firmware/libcommon/source/sniffer.c: https://gerrit.osmocom.org/#/c/9873/5/firmware/libcommon/source/sniffer.c@275 PS5, Line 275: TRACE_ERROR("ATR buffer overflow\n\r"); > this might be something worth counting and/or reporting to the host? Keep in mind, the normal user […] this is merely a security check to prevent out of bound read later on. the parse ATR code should already have prevented this case. but the bigger question is how much of the communication parsing check do we want to send to the user (e.g. invalid class, ...) -- To view, visit https://gerrit.osmocom.org/9873 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ice7817480705f2124b08c1ff9a8826558b6d8b2b Gerrit-Change-Number: 9873 Gerrit-PatchSet: 6 Gerrit-Owner: Kévin Redon <kredon at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Kévin Redon <kredon at sysmocom.de> Gerrit-Comment-Date: Wed, 04 Jul 2018 13:22:09 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180704/8183a10d/attachment.htm>