This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9878 )
Change subject: sniffing: move conversion convertion and flag processing from ISR to main loop to keep ISR fast and focus on data capture
......................................................................
Patch Set 7: Code-Review+1
(1 comment)
https://gerrit.osmocom.org/#/c/9878/7/firmware/libcommon/source/sniffer.c
File firmware/libcommon/source/sniffer.c:
https://gerrit.osmocom.org/#/c/9878/7/firmware/libcommon/source/sniffer.c@841
PS7, Line 841: struct simtrace_msg_hdr *usb_msg_header;
: usb_msg->l1h = msgb_put(usb_msg, sizeof(*usb_msg_header));
: usb_msg_header = (struct simtrace_msg_hdr *) usb_msg->l1h;
: memset(usb_msg_header, 0, sizeof(*usb_msg_header));
: usb_msg_header->msg_class = SIMTRACE_MSGC_SNIFF;
: usb_msg_header->msg_type = SIMTRACE_MSGT_SNIFF_CHANGE;
: usb_msg->l2h = usb_msg->l1h + sizeof(*usb_msg_header);
: struct sniff_change *usb_sniff_change;
: usb_sniff_change = (struct sniff_change *) msgb_put(usb_msg, sizeof(*usb_sniff_change));
: usb_sniff_change->flags = flags;
: usb_msg_header->msg_len = msgb_length(usb_msg);
this will need to be changed according to the API suggestions I posted against an earlier patch in the series
--
To view, visit https://gerrit.osmocom.org/9878
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieefa8a5f81dbcc12c1ad3059660dbffa0c1a4961
Gerrit-Change-Number: 9878
Gerrit-PatchSet: 7
Gerrit-Owner: Kévin Redon <kredon at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Wed, 04 Jul 2018 12:22:02 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180704/284e3596/attachment.htm>