Change in simtrace2[master]: sniffer: display F and D values frim PPS

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed Jul 4 12:19:12 UTC 2018


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9875 )

Change subject: sniffer: display F and D values frim PPS
......................................................................


Patch Set 7: Code-Review+2

(1 comment)

https://gerrit.osmocom.org/#/c/9875/7/firmware/libcommon/include/iso7816_fidi.h
File firmware/libcommon/include/iso7816_fidi.h:

https://gerrit.osmocom.org/#/c/9875/7/firmware/libcommon/include/iso7816_fidi.h@6
PS7, Line 6: extern const uint16_t fi_table[];
normally I would recommend to have an accessor function or macro to catch out-of-bounds array index overflow.  However, the [current] single user of those tables is clearly only passing 4-bit wide values as array index, so it is still ok.  However, future users may differ.



-- 
To view, visit https://gerrit.osmocom.org/9875
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3641dcb6c24695a6d3dd3a1ee4333f56a07c99f0
Gerrit-Change-Number: 9875
Gerrit-PatchSet: 7
Gerrit-Owner: Kévin Redon <kredon at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Wed, 04 Jul 2018 12:19:12 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180704/59ffe052/attachment.htm>


More information about the gerrit-log mailing list