Change in simtrace2[master]: sniff: print parsed ATR and PPS; use red LED to show main application...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed Jul 4 11:57:31 UTC 2018


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9865 )

Change subject: sniff: print parsed ATR and PPS; use red LED to show main application is running; use green LED to indicate activity (message parsed)
......................................................................


Patch Set 3: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/#/c/9865/3//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/9865/3//COMMIT_MSG@7
PS3, Line 7: sniff: print parsed ATR and PPS; use red LED to show main application is running; use green LED to indicate activity (message parsed)
cosmietics: I think it's more "logical" if the permanent gren LED indicated "I'm running main program, everything is OK" and the blinking red led would indicate activity.  Not critical, just some idea...



-- 
To view, visit https://gerrit.osmocom.org/9865
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e906bdbf2c91e608757ae442dfb241f981b8f1e
Gerrit-Change-Number: 9865
Gerrit-PatchSet: 3
Gerrit-Owner: Kévin Redon <kredon at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Wed, 04 Jul 2018 11:57:31 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180704/35a2f6d3/attachment.htm>


More information about the gerrit-log mailing list