Change in osmo-mgw[master]: stats: replace packet statistic counters with libosmocore rate counters

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Tue Jul 3 17:02:58 UTC 2018


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9837 )

Change subject: stats: replace packet statistic counters with libosmocore rate counters
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/9837/1/include/osmocom/mgcp/mgcp_internal.h
File include/osmocom/mgcp/mgcp_internal.h:

https://gerrit.osmocom.org/#/c/9837/1/include/osmocom/mgcp/mgcp_internal.h@104
PS1, Line 104: 		struct rate_ctr *packets_rx;
I think the more logical / common approach would be to simply have one pointer to the rate counter group here? Please compare with other osmocom code using rate_ctr[_group]



-- 
To view, visit https://gerrit.osmocom.org/9837
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I47c5c9006df5044e59ddebb895e62adb849d72d5
Gerrit-Change-Number: 9837
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-CC: Harald Welte <laforge at gnumonks.org>
Gerrit-Comment-Date: Tue, 03 Jul 2018 17:02:58 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180703/b0e4a573/attachment.htm>


More information about the gerrit-log mailing list