This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9853 )
Change subject: ISO7816: change update_fidi to use provided USART, and disable write protection for USART register if required
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://gerrit.osmocom.org/#/c/9853/1/firmware/libcommon/source/simtrace_iso7816.c
File firmware/libcommon/source/simtrace_iso7816.c:
https://gerrit.osmocom.org/#/c/9853/1/firmware/libcommon/source/simtrace_iso7816.c@138
PS1, Line 138: TRACE_INFO("updated USART Fi(%u)/Di(%u) ratio(%d): %u\n\r", fi, di, ratio, usart->US_FIDI);
it would make sense to print the UASRT number as otherwise you don't know if a given TRACE/log message relates to UART0 or USART1
--
To view, visit https://gerrit.osmocom.org/9853
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I716f4bc3a22800cbce402b146f14ef8b2aab2a98
Gerrit-Change-Number: 9853
Gerrit-PatchSet: 1
Gerrit-Owner: Kévin Redon <kredon at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Tue, 03 Jul 2018 16:58:45 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180703/826e57a3/attachment.htm>