This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9842 ) Change subject: add more USB configuration checks and error messages ...................................................................... Patch Set 1: Code-Review-1 (5 comments) https://gerrit.osmocom.org/#/c/9842/1/firmware/apps/trace/main.c File firmware/apps/trace/main.c: https://gerrit.osmocom.org/#/c/9842/1/firmware/apps/trace/main.c@7 PS1, Line 7: Affero no Affero GPL in SIMtrace, I think we should stick to GPLv2-or-later here. https://gerrit.osmocom.org/#/c/9842/1/firmware/apps/trace/main.c@105 PS1, Line 105: sizeof(config_func_ptrs)/sizeof(config_func_ptrs[0] we should be able to use ARRAY_SIZE here? https://gerrit.osmocom.org/#/c/9842/1/firmware/apps/trace/main.c@202 PS1, Line 202: sizeof(config_func_ptrs)/sizeof(config_func_ptrs[0]) same comment regarding ARRAY_SIZE https://gerrit.osmocom.org/#/c/9842/1/firmware/apps/trace/main.c@238 PS1, Line 238: sizeof(config_func_ptrs)/sizeof(config_func_ptrs[0]) and once more ARRAY_SIZE https://gerrit.osmocom.org/#/c/9842/1/firmware/apps/trace/main.c@247 PS1, Line 247: sizeof(config_func_ptrs)/sizeof(config_func_ptrs[0]) one more time.. -- To view, visit https://gerrit.osmocom.org/9842 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I20f8018cd5087254dfbfad40b73803390aa84183 Gerrit-Change-Number: 9842 Gerrit-PatchSet: 1 Gerrit-Owner: Kévin Redon <kredon at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Tue, 03 Jul 2018 16:53:48 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180703/71a305c5/attachment.htm>