Change in libosmo-sccp[master]: tweak the default point codes used by sccp_demo_user

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Tue Jul 3 11:45:46 UTC 2018


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9652 )

Change subject: tweak the default point codes used by sccp_demo_user
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.osmocom.org/#/c/9652/1//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/9652/1//COMMIT_MSG@17
PS1, Line 17: -1
As far as I can see, the old code was using -1, not the new code? (leaving that aside, I don't even remember what -1 was intended to signify)


https://gerrit.osmocom.org/#/c/9652/1//COMMIT_MSG@22
PS1, Line 22: Use the same default values for both client and
            : server modes
this wording would mean that both the client and server want to use "23" as local code and "1" as remote point code, and they cannot connect to each other? I suppose this is not what you meant to say?



-- 
To view, visit https://gerrit.osmocom.org/9652
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7432e6fc2617e0fd77a098fcd7d14abc40db7229
Gerrit-Change-Number: 9652
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Tue, 03 Jul 2018 11:45:46 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180703/516946d6/attachment.htm>


More information about the gerrit-log mailing list