Change in gapk[master]: fmt_ti.c: fix: properly pre-clean the output buffer

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Mon Jul 2 10:04:29 UTC 2018


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/9794 )

Change subject: fmt_ti.c: fix: properly pre-clean the output buffer
......................................................................


Patch Set 1:

> This just looks like a false positive to me.
 > Sure msb_put_bit will read an uninitiated value, but the end result
 > should, in the end, always be the same.

Well, most likely this is not a false-positive.
It actually affects the output.
http://osmocom.org/issues/2934

To confirm this, I have implemented a simple hack,
which randomizes output buffers of processing queue
before each iteration - 'make check' failed for this format.

I think the AddressSanitizer does the same trick.


-- 
To view, visit https://gerrit.osmocom.org/9794
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: gapk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I79df56dde23702b0eac8e8fdbc0efd270cc0ace4
Gerrit-Change-Number: 9794
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: tnt <tnt at 246tNt.com>
Gerrit-Comment-Date: Mon, 02 Jul 2018 10:04:29 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180702/3c140b34/attachment.htm>


More information about the gerrit-log mailing list