[PATCH] osmo-mgw[master]: client: do not accept endpoint ids without @ character in re...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Wed Jan 31 16:42:31 UTC 2018


Review at  https://gerrit.osmocom.org/6220

client: do not accept endpoint ids without @ character in responses

At the moment the client does not check if the endpoint identifier
that is returned from the MGW actually contains an @ character.

- Check if the endpoint id in the response contains an @ character.

Change-Id: I6073419a4b6cdcd31880672564f0861cb4bd02f5
---
M src/libosmo-mgcp-client/mgcp_client.c
1 file changed, 7 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/20/6220/1

diff --git a/src/libosmo-mgcp-client/mgcp_client.c b/src/libosmo-mgcp-client/mgcp_client.c
index d868c7f..593d305 100644
--- a/src/libosmo-mgcp-client/mgcp_client.c
+++ b/src/libosmo-mgcp-client/mgcp_client.c
@@ -363,6 +363,13 @@
 				rc = -EINVAL;
 				goto exit;
 			}
+
+			/* A specific endpoint identifier returned by the MGW
+			 * must contain an @ character */
+			if (strstr(r->head.endpoint, "@") == NULL) {
+				rc = -EINVAL;
+				goto exit;
+			}
 			break;
 		case 'I':
 			rc = mgcp_parse_head_param(r->head.conn_id,

-- 
To view, visit https://gerrit.osmocom.org/6220
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6073419a4b6cdcd31880672564f0861cb4bd02f5
Gerrit-PatchSet: 1
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>



More information about the gerrit-log mailing list