This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgPatch Set 1: (2 comments) looks fine to me, besides having the value also listed in "show bts" so one can introspect the current value as a system administrator. It would also make sense to expose the value by other means. I myself haven't used the stasd exporter facilities in libosmocore, but exporting it as a "gauge" type sounds like the most logical way. From a quick glance it seems it supports the gauge "|g" type by means of OSMO_STAT_ITEM_NO_UNIT. The point here is that this is a value that you might want to plot on a per-bts basis over time. Could be a follow-up patch. https://gerrit.osmocom.org/#/c/6211/1/src/libbsc/abis_rsl.c File src/libbsc/abis_rsl.c: Line 1791: /* Set all request references and wait indications to the same value. it might make sense to state explicitly here that the spec requires entries to be duplicated if unused. This is highly unusual and deserves special mention. https://gerrit.osmocom.org/#/c/6211/1/src/libbsc/net_init.c File src/libbsc/net_init.c: Line 79: osmo_timer_setup(&net->t3122_chan_load_timer, update_t3122_chan_load_timer, net); I think it might make sense to have each BTS have its own timer, rather than handling all BTSs at once. Why? Becaus at large number of BTSs, we might introduce a load spike at one point in time which normally could be spred more evenly. But then, ignore that. The computation is not very expensive, so it most likely doesn't matter. And on those systems where it matters (deeply embedded) we only have 1-2 BTS anyway. Maybe add a comment here that if it ever becomes ac oncern, each BTS could be staggered. -- To view, visit https://gerrit.osmocom.org/6211 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I57e38f6d6ba3b23cc6e1f9520b90261dbb1f1cec Gerrit-PatchSet: 1 Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: Yes