This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgPatch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/6205/1/ggsn_tests/GGSN_Tests.ttcn File ggsn_tests/GGSN_Tests.ttcn: Line 1071: function f_wait_icmp4_echo_request(PdpContext ctx) runs on GT_CT { rather than having these copy+pasted wait-for-... functions, one simple approach might be to have an template argument like "f_wait_icmp4(PdpContext ctx, template PDU_ICMP expected)" So the caller would then call "f_wait_icmp4(pdp_ctx, tr_ICMPv4_EQ)" and you only have one of those functions for v4 and one for v6, rather than many of them that look more or less the same. -- To view, visit https://gerrit.osmocom.org/6205 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I67c04b056cc5c092d357abbb084b7665f59eaf3a Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: Yes