[MERGED] osmo-ttcn3-hacks[master]: GSUP_Types: Add tr_GSUP_IMSI as helper for messages with IMS...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Sat Jan 27 18:01:32 UTC 2018


Harald Welte has submitted this change and it was merged.

Change subject: GSUP_Types: Add tr_GSUP_IMSI as helper for messages with IMSI as first IE
......................................................................


GSUP_Types: Add tr_GSUP_IMSI as helper for messages with IMSI as first IE

Change-Id: Ie1b9682d102da28fa7de4cb391d61aeb52f1676b
---
M library/GSUP_Types.ttcn
1 file changed, 9 insertions(+), 7 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/library/GSUP_Types.ttcn b/library/GSUP_Types.ttcn
index b9c6f39..1e28ffe 100644
--- a/library/GSUP_Types.ttcn
+++ b/library/GSUP_Types.ttcn
@@ -222,6 +222,11 @@
 	ies := ies
 }
 
+template GSUP_PDU tr_GSUP_IMSI(template GSUP_MessageType msgt := ?, template hexstring imsi) := {
+	msg_type := msgt,
+	ies := { tr_GSUP_IE_IMSI(imsi), * }
+}
+
 template GSUP_PDU ts_GSUP(GSUP_MessageType msgt, GSUP_IEs ies := {}) := {
 	msg_type := msgt,
 	ies := ies
@@ -231,7 +236,7 @@
 	ts_GSUP(OSMO_GSUP_MSGT_SEND_AUTH_INFO_REQUEST, { valueof(ts_GSUP_IE_IMSI(imsi)) });
 
 template GSUP_PDU tr_GSUP_SAI_REQ(template hexstring imsi) :=
-	tr_GSUP(OSMO_GSUP_MSGT_SEND_AUTH_INFO_REQUEST, { tr_GSUP_IE_IMSI(imsi), * });
+	tr_GSUP_IMSI(OSMO_GSUP_MSGT_SEND_AUTH_INFO_REQUEST, imsi);
 
 template (value) GSUP_PDU ts_GSUP_SAI_RES(hexstring imsi, GSUP_IE auth_tuple) :=
 	ts_GSUP(OSMO_GSUP_MSGT_SEND_AUTH_INFO_RESULT, {
@@ -251,8 +256,7 @@
 			tr_GSUP_IE_IMSI(imsi), *, tr_GSUP_IE(OSMO_GSUP_AUTH_TUPLE_IE), * });
 
 template GSUP_PDU tr_GSUP_UL_REQ(template hexstring imsi) :=
-	tr_GSUP(OSMO_GSUP_MSGT_UPDATE_LOCATION_REQUEST, {
-			tr_GSUP_IE_IMSI(imsi), * });
+	tr_GSUP_IMSI(OSMO_GSUP_MSGT_UPDATE_LOCATION_REQUEST, imsi);
 
 template (value) GSUP_PDU ts_GSUP_UL_RES(hexstring imsi) :=
 	ts_GSUP(OSMO_GSUP_MSGT_UPDATE_LOCATION_RESULT, { valueof(ts_GSUP_IE_IMSI(imsi)) });
@@ -266,12 +270,10 @@
 			valueof(ts_GSUP_IE_IMSI(imsi)), valueof(ts_GSUP_IE_MSISDN(msisdn)) });
 
 template GSUP_PDU tr_GSUP_ISD_RES(template hexstring imsi) :=
-	tr_GSUP(OSMO_GSUP_MSGT_INSERT_DATA_RESULT, {
-			tr_GSUP_IE_IMSI(imsi), * });
+	tr_GSUP_IMSI(OSMO_GSUP_MSGT_INSERT_DATA_RESULT, imsi);
 
 template GSUP_PDU tr_GSUP_AUTH_FAIL_IND(hexstring imsi) :=
-	tr_GSUP(OSMO_GSUP_MSGT_AUTH_FAIL_REPORT, {
-			tr_GSUP_IE_IMSI(imsi), * });
+	tr_GSUP_IMSI(OSMO_GSUP_MSGT_AUTH_FAIL_REPORT, imsi);
 
 template GSUP_IE tr_GSUP_IE(template GSUP_IEI iei, template GSUP_IeValue val := ?) := {
 	tag := iei,

-- 
To view, visit https://gerrit.osmocom.org/6136
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie1b9682d102da28fa7de4cb391d61aeb52f1676b
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list