[PATCH] osmo-ttcn3-hacks[master]: msc: Accept optional f_init_handler() argument for Tguard

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Sat Jan 27 13:27:53 UTC 2018


Review at  https://gerrit.osmocom.org/6131

msc: Accept optional f_init_handler() argument for Tguard

Some tests may want an extended guard timer as they're waiting for
some particularly slow events.  They can override the default now.

Change-Id: Iee6f50559a8fe45c7655b9f41e7fa163199b39a6
---
M msc_tests/BSC_ConnectionHandler.ttcn
M msc_tests/MSC_Tests.ttcn
2 files changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/31/6131/1

diff --git a/msc_tests/BSC_ConnectionHandler.ttcn b/msc_tests/BSC_ConnectionHandler.ttcn
index 843197e..97c02b8 100644
--- a/msc_tests/BSC_ConnectionHandler.ttcn
+++ b/msc_tests/BSC_ConnectionHandler.ttcn
@@ -62,11 +62,11 @@
 }
 
 /* init function, called as first function in new BSC_ConnHdlr */
-function f_init_handler(BSC_ConnHdlrPars pars) runs on BSC_ConnHdlr {
+function f_init_handler(BSC_ConnHdlrPars pars, float t_guard := 60.0) runs on BSC_ConnHdlr {
 	/* make parameters available via component variable */
 	g_pars := pars;
 	/* Start guard timer and activate it as default */
-	g_Tguard.start;
+	g_Tguard.start(t_guard);
 	activate(as_Tguard());
 }
 
diff --git a/msc_tests/MSC_Tests.ttcn b/msc_tests/MSC_Tests.ttcn
index 2f85ab4..2e9176f 100644
--- a/msc_tests/MSC_Tests.ttcn
+++ b/msc_tests/MSC_Tests.ttcn
@@ -1406,7 +1406,7 @@
 
 /* Test MT Call T310 timer */
 private function f_tc_mt_t310(charstring id, BSC_ConnHdlrPars pars) runs on BSC_ConnHdlr {
-	f_init_handler(pars);
+	f_init_handler(pars, 200.0);
 	var CallParameters cpars := valueof(t_CallParams('123456'H, 0));
 	var MNCC_PDU mncc;
 	var MgcpCommand mgcp_cmd;

-- 
To view, visit https://gerrit.osmocom.org/6131
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iee6f50559a8fe45c7655b9f41e7fa163199b39a6
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>



More information about the gerrit-log mailing list