osmo-bts[master]: rsl: do not allow MODE MODIFY request with unsupp. codec/rate

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Fri Jan 26 16:21:27 UTC 2018


Patch Set 1:

(3 comments)

https://gerrit.osmocom.org/#/c/6097/1/src/common/bts.c
File src/common/bts.c:

Line 679: int bts_supports_cm(struct gsm_bts_role_bts *bts,
Why not to use bool here?


Line 693: 	for (i = 0;; i++) {
This way: (i = 0; i < _GSM_PCHAN_MAX; i++)


Line 702: 		if (supported[i].pchan == _GSM_PCHAN_MAX)
This could be moved to the 'for' condition...


-- 
To view, visit https://gerrit.osmocom.org/6097
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id9b222b7ab19ece90591718bc562b3a8c5e02023
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list