This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has submitted this change and it was merged. Change subject: client: make callid in MDCX mandatory ...................................................................... client: make callid in MDCX mandatory An MDCX without call-id does not make much sense. The call-id is an integral element of the MDCX message to ensure that the correct call is modified. - update the presence check bitmasks to mark the call-id field mandatory for MDCX requests Change-Id: Id2bcc3a68139e0d935790bcea2ef91eaf6291aa3 --- M src/libosmo-mgcp-client/mgcp_client.c 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Harald Welte: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/libosmo-mgcp-client/mgcp_client.c b/src/libosmo-mgcp-client/mgcp_client.c index f094a09..135aed0 100644 --- a/src/libosmo-mgcp-client/mgcp_client.c +++ b/src/libosmo-mgcp-client/mgcp_client.c @@ -728,6 +728,7 @@ MGCP_MSG_PRESENCE_CALL_ID | \ MGCP_MSG_PRESENCE_CONN_MODE) #define MGCP_MDCX_MANDATORY (MGCP_MSG_PRESENCE_ENDPOINT | \ + MGCP_MSG_PRESENCE_CALL_ID | \ MGCP_MSG_PRESENCE_CONN_ID) #define MGCP_DLCX_MANDATORY (MGCP_MSG_PRESENCE_ENDPOINT) #define MGCP_AUEP_MANDATORY (MGCP_MSG_PRESENCE_ENDPOINT) -- To view, visit https://gerrit.osmocom.org/5993 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id2bcc3a68139e0d935790bcea2ef91eaf6291aa3 Gerrit-PatchSet: 1 Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier at sysmocom.de>