This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Pau Espin Pedrol gerrit-no-reply at lists.osmocom.orgReview at https://gerrit.osmocom.org/6073 gtp/gtp.c: Mark non exported functions as static Functions not exported in gtp.h should be static. There's no need to mark functions as extern in the .c file. Change-Id: Ie61d5c6e0ae45ef3885911cedf71c826ed1705d0 --- M gtp/gtp.c 1 file changed, 16 insertions(+), 16 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/73/6073/1 diff --git a/gtp/gtp.c b/gtp/gtp.c index 9dabcd2..c087740 100644 --- a/gtp/gtp.c +++ b/gtp/gtp.c @@ -197,7 +197,7 @@ return 0; } -extern int gtp_set_cb_data_ind(struct gsn_t *gsn, +int gtp_set_cb_data_ind(struct gsn_t *gsn, int (*cb_data_ind) (struct pdp_t * pdp, void *pack, unsigned len)) { @@ -402,7 +402,7 @@ * a predefined timeout. *************************************************************/ -int gtp_req(struct gsn_t *gsn, int version, struct pdp_t *pdp, +static int gtp_req(struct gsn_t *gsn, int version, struct pdp_t *pdp, union gtp_packet *packet, int len, struct in_addr *inetaddr, void *cbp) { @@ -477,7 +477,7 @@ * Remove signalling packet from retransmission queue. * return 0 on success, EOF if packet was not found */ -int gtp_conf(struct gsn_t *gsn, int version, struct sockaddr_in *peer, +static int gtp_conf(struct gsn_t *gsn, int version, struct sockaddr_in *peer, union gtp_packet *packet, int len, uint8_t * type, void **cbp) { uint8_t ver = GTPHDR_F_GET_VER(packet->flags); @@ -568,7 +568,7 @@ return 0; } -int gtp_resp(int version, struct gsn_t *gsn, struct pdp_t *pdp, +static int gtp_resp(int version, struct gsn_t *gsn, struct pdp_t *pdp, union gtp_packet *packet, int len, struct sockaddr_in *peer, int fd, uint16_t seq, uint64_t tid) { @@ -626,7 +626,7 @@ return 0; } -int gtp_notification(struct gsn_t *gsn, int version, +static int gtp_notification(struct gsn_t *gsn, int version, union gtp_packet *packet, int len, struct sockaddr_in *peer, int fd, uint16_t seq) { @@ -671,7 +671,7 @@ return 0; } -int gtp_dublicate(struct gsn_t *gsn, int version, +static int gtp_dublicate(struct gsn_t *gsn, int version, struct sockaddr_in *peer, uint16_t seq) { struct qmsg_t *qmsg; @@ -1016,7 +1016,7 @@ } /* Send off an Supported Extension Headers Notification */ -int gtp_extheader_req(struct gsn_t *gsn, int version, struct sockaddr_in *peer, +static int gtp_extheader_req(struct gsn_t *gsn, int version, struct sockaddr_in *peer, int fd, void *pack, unsigned len) { union gtp_packet packet; @@ -1037,7 +1037,7 @@ } /* Handle a Supported Extension Headers Notification */ -int gtp_extheader_ind(struct gsn_t *gsn, struct sockaddr_in *peer, +static int gtp_extheader_ind(struct gsn_t *gsn, struct sockaddr_in *peer, void *pack, unsigned len) { @@ -1060,7 +1060,7 @@ *************************************************************/ /* API: Send Create PDP Context Request (7.3.1) */ -extern int gtp_create_context_req(struct gsn_t *gsn, struct pdp_t *pdp, +int gtp_create_context_req(struct gsn_t *gsn, struct pdp_t *pdp, void *cbp) { union gtp_packet packet; @@ -1936,7 +1936,7 @@ } /* Send Update PDP Context Response */ -int gtp_update_pdp_resp(struct gsn_t *gsn, int version, +static int gtp_update_pdp_resp(struct gsn_t *gsn, int version, struct sockaddr_in *peer, int fd, void *pack, unsigned len, struct pdp_t *pdp, uint8_t cause) @@ -1998,7 +1998,7 @@ } /* Handle Update PDP Context Request */ -int gtp_update_pdp_ind(struct gsn_t *gsn, int version, +static int gtp_update_pdp_ind(struct gsn_t *gsn, int version, struct sockaddr_in *peer, int fd, void *pack, unsigned len) { @@ -2226,7 +2226,7 @@ } /* Handle Update PDP Context Response */ -int gtp_update_pdp_conf(struct gsn_t *gsn, int version, +static int gtp_update_pdp_conf(struct gsn_t *gsn, int version, struct sockaddr_in *peer, void *pack, unsigned len) { struct pdp_t *pdp; @@ -2614,7 +2614,7 @@ } /* Send Error Indication (response to a GPDU message) - 3GPP TS 29.060 7.3.7 */ -int gtp_error_ind_resp(struct gsn_t *gsn, int version, +static int gtp_error_ind_resp(struct gsn_t *gsn, int version, struct sockaddr_in *peer, int fd, void *pack, unsigned len) { @@ -2636,7 +2636,7 @@ } /* Handle Error Indication */ -int gtp_error_ind_conf(struct gsn_t *gsn, int version, +static int gtp_error_ind_conf(struct gsn_t *gsn, int version, struct sockaddr_in *peer, void *pack, unsigned len) { union gtpie_member *ie[GTPIE_SIZE]; @@ -2692,7 +2692,7 @@ return 0; } -int gtp_gpdu_ind(struct gsn_t *gsn, int version, +static int gtp_gpdu_ind(struct gsn_t *gsn, int version, struct sockaddr_in *peer, int fd, void *pack, unsigned len) { @@ -3296,7 +3296,7 @@ * Conversion functions *************************************************************/ -int char2ul_t(char *src, struct ul_t dst) +static int char2ul_t(char *src, struct ul_t dst) { dst.l = strlen(src) + 1; dst.v = malloc(dst.l); -- To view, visit https://gerrit.osmocom.org/6073 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie61d5c6e0ae45ef3885911cedf71c826ed1705d0 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>