[PATCH] osmo-bsc[master]: Remove an unused variable.

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Stefan Sperling gerrit-no-reply at lists.osmocom.org
Thu Jan 25 15:09:58 UTC 2018


Hello Jenkins Builder,

I'd like you to reexamine a change.  Please visit

    https://gerrit.osmocom.org/6064

to look at the new patch set (#2).

Remove an unused variable.

Local variable is_lu in rsl_rx_chan_rqd() has been unused
since commit 6082a377f57901302816a2e57e75a3f262b7b7e6.

Change-Id: I67594afcfa4104e91352d50f40ae9f2bc20f4cd1
---
M src/libbsc/abis_rsl.c
1 file changed, 0 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/64/6064/2

diff --git a/src/libbsc/abis_rsl.c b/src/libbsc/abis_rsl.c
index b54fab8..eced0e2 100644
--- a/src/libbsc/abis_rsl.c
+++ b/src/libbsc/abis_rsl.c
@@ -1860,7 +1860,6 @@
 	enum gsm_chreq_reason_t chreq_reason;
 	struct gsm_lchan *lchan;
 	uint8_t rqd_ta;
-	int is_lu;
 
 	uint16_t arfcn;
 	uint8_t subch;
@@ -1892,12 +1891,6 @@
 	lctype = get_ctype_by_chreq(bts->network, rqd_ref->ra);
 
 	rate_ctr_inc(&bts->bts_ctrs->ctr[BTS_CTR_CHREQ_TOTAL]);
-
-	/*
-	 * We want LOCATION UPDATES to succeed and will assign a TCH
-	 * if we have no SDCCH available.
-	 */
-	is_lu = !!(chreq_reason == GSM_CHREQ_REASON_LOCATION_UPD);
 
 	/* check availability / allocate channel
 	 *

-- 
To view, visit https://gerrit.osmocom.org/6064
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I67594afcfa4104e91352d50f40ae9f2bc20f4cd1
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>



More information about the gerrit-log mailing list