[MERGED] libosmocore[master]: gsm48_pdisc_names: Use conscise, short names

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed Jan 24 16:25:05 UTC 2018


Harald Welte has submitted this change and it was merged.

Change subject: gsm48_pdisc_names: Use conscise, short names
......................................................................


gsm48_pdisc_names: Use conscise, short names

Some times I *really* regret ever having merged OSMO_VALUE_STRING,
as it generates completely unusable and way too long strings :(

Change-Id: I8de7c01f9ea1d66c384e57449c4140186f5ce6c5
---
M src/gsm/gsm48.c
1 file changed, 15 insertions(+), 15 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/gsm/gsm48.c b/src/gsm/gsm48.c
index 8876059..4570802 100644
--- a/src/gsm/gsm48.c
+++ b/src/gsm/gsm48.c
@@ -740,21 +740,21 @@
 
 /*! TS 04.08 Protocol Descriptor names */
 const struct value_string gsm48_pdisc_names[] = {
-	OSMO_VALUE_STRING(GSM48_PDISC_GROUP_CC),
-	OSMO_VALUE_STRING(GSM48_PDISC_BCAST_CC),
-	OSMO_VALUE_STRING(GSM48_PDISC_PDSS1),
-	OSMO_VALUE_STRING(GSM48_PDISC_CC),
-	OSMO_VALUE_STRING(GSM48_PDISC_PDSS2),
-	OSMO_VALUE_STRING(GSM48_PDISC_MM),
-	OSMO_VALUE_STRING(GSM48_PDISC_RR),
-	OSMO_VALUE_STRING(GSM48_PDISC_MM_GPRS),
-	OSMO_VALUE_STRING(GSM48_PDISC_SMS),
-	OSMO_VALUE_STRING(GSM48_PDISC_SM_GPRS),
-	OSMO_VALUE_STRING(GSM48_PDISC_NC_SS),
-	OSMO_VALUE_STRING(GSM48_PDISC_LOC),
-	OSMO_VALUE_STRING(GSM48_PDISC_EXTEND),
-	OSMO_VALUE_STRING(GSM48_PDISC_MASK),
-	OSMO_VALUE_STRING(GSM48_PDISC_USSD),
+	{ GSM48_PDISC_GROUP_CC,		"VGCC" },
+	{ GSM48_PDISC_BCAST_CC,		"VBCC" },
+	{ GSM48_PDISC_PDSS1,		"PDSS1" },
+	{ GSM48_PDISC_CC,		"CC" },
+	{ GSM48_PDISC_PDSS2,		"PDSS2" },
+	{ GSM48_PDISC_MM,		"MM" },
+	{ GSM48_PDISC_RR,		"RR" },
+	{ GSM48_PDISC_MM_GPRS,		"GMM" },
+	{ GSM48_PDISC_SMS,		"SMS" },
+	{ GSM48_PDISC_SM_GPRS,		"SM" },
+	{ GSM48_PDISC_NC_SS,		"NCSS" },
+	{ GSM48_PDISC_LOC,		"LCS" },
+	{ GSM48_PDISC_EXTEND,		"EXTD" },
+	{ GSM48_PDISC_MASK,		"MASK" },
+	{ GSM48_PDISC_USSD,		"USSD" },
 	{ 0, NULL }
 };
 

-- 
To view, visit https://gerrit.osmocom.org/6020
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8de7c01f9ea1d66c384e57449c4140186f5ce6c5
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list