This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has submitted this change and it was merged. Change subject: sccp_types.h: Fix value for SCCP_REFUSAL_UNEQUIPPED_USER ...................................................................... sccp_types.h: Fix value for SCCP_REFUSAL_UNEQUIPPED_USER It seems we have been sending the wrong numeric value in SCCP connection refusal due to an unqeuipped user. It turns out our list of refusal causes was missing one entry, causing an off-by-one for this refusal cause. While at it, add a comment which section of which spec is relevant for this enum. Change-Id: I113645bd6df1ec9ae5137977028df38560fc4789 --- M include/sccp/sccp_types.h 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Max: Looks good to me, but someone else must approve Harald Welte: Looks good to me, approved Jenkins Builder: Verified diff --git a/include/sccp/sccp_types.h b/include/sccp/sccp_types.h index 962bde4..ab7f74f 100644 --- a/include/sccp/sccp_types.h +++ b/include/sccp/sccp_types.h @@ -245,6 +245,7 @@ SCCP_ERROR_UNQUALIFIED = 4, }; +/* ITU=T Q.713 Section 3.15 */ enum sccp_refusal_cause { SCCP_REFUSAL_END_USER_ORIGINATED = 0, SCCP_REFUSAL_END_USER_CONGESTION = 1, @@ -264,7 +265,8 @@ SCCP_REFUSAL_UNQUALIFIED = 15, SCCP_REFUSAL_HOP_COUNTER_VIOLATION = 16, SCCP_REFUSAL_SCCP_FAILURE = 17, - SCCP_REFUSAL_UNEQUIPPED_USER = 18, + SCCP_REFUSAL_NO_TRANS_FOR_ADDRESS_NATURE = 18, + SCCP_REFUSAL_UNEQUIPPED_USER = 19, }; /* -- To view, visit https://gerrit.osmocom.org/5860 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I113645bd6df1ec9ae5137977028df38560fc4789 Gerrit-PatchSet: 1 Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Owner: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <msuraev at sysmocom.de>