osmo-mgw[master]: protocol: fix missing carriage return

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Mon Jan 22 12:32:48 UTC 2018


Patch Set 1:

> what does the spec say about line endings?

RFC3435 Appendix A: Formal Syntax Description of the Protocol (which is hard to follow) defines EOL as CRLF / LF. In RFC2327 Chapter 6 SDP Specification it is mentioned that it should be an \r\n but \n should be tolerated as well, thats probably also the reason why wireshark did not complain.

"Text records such as the session name and information are bytes    strings which may contain any byte with the exceptions of 0x00 (Nul), 0x0a (ASCII newline) and 0x0d (ASCII carriage return). The sequence CRLF (0x0d0a) is used to end a record, although parsers should be tolerant and also accept records terminated with a single newline   character.  By default these byte strings contain ISO-10646 characters in UTF-8 encoding, but this default may be changed using the `charset' attribute.

-- 
To view, visit https://gerrit.osmocom.org/5981
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0cd80afae65accd3b4ddc5d82e5d30385879141c
Gerrit-PatchSet: 1
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-HasComments: No



More information about the gerrit-log mailing list