osmo-bts[master]: Remove unneeded LIBOSMOCORE_CFLAGS from tests

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Sun Jan 21 22:40:14 UTC 2018


Patch Set 1: -Code-Review

(1 comment)

https://gerrit.osmocom.org/#/c/5961/1/configure.ac
File configure.ac:

Line 186: CPPFLAGS="$CPPFLAGS"
> this is NOOP and can be removed.
Ah I see you re-use it in next patch adding an extra -I...
Would have been clearer stating so in the commit description, swapping order of the 2 commits or removing this + oldCPPFLAGs lines and readding them in following commit.

But not that important, so I remove the -1 but please check the other comment.


-- 
To view, visit https://gerrit.osmocom.org/5961
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I64bf1acb9db999567e8a2a6690cfc96d6e4b7ee1
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list