[MERGED] osmo-bsc[master]: vty: change handover command's arg LCHAN_NR to <0-7>

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri Jan 19 22:09:30 UTC 2018


Harald Welte has submitted this change and it was merged.

Change subject: vty: change handover command's arg LCHAN_NR to <0-7>
......................................................................


vty: change handover command's arg LCHAN_NR to <0-7>

Even thought the lchan number range depends on the pchan, using LCHAN_NR allows
passing arbitrary arguments. Limit it to 0-7.

Change-Id: I2c078b420b6183862acb5c18d1230cf8f6c9f0ce
---
M src/libbsc/bsc_vty.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/libbsc/bsc_vty.c b/src/libbsc/bsc_vty.c
index dcdd28a..983ce20 100644
--- a/src/libbsc/bsc_vty.c
+++ b/src/libbsc/bsc_vty.c
@@ -1344,7 +1344,7 @@
 
 DEFUN(handover_subscr_conn,
       handover_subscr_conn_cmd,
-      "handover <0-255> <0-255> <0-7> LCHAN_NR <0-255>",
+      "handover <0-255> <0-255> <0-7> <0-7> <0-255>",
       "Handover subscriber connection to other BTS\n"
       "BTS Number (current)\n" "TRX Number\n" "Timeslot Number\n"
       LCHAN_NR_STR "BTS Number (new)\n")

-- 
To view, visit https://gerrit.osmocom.org/5931
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2c078b420b6183862acb5c18d1230cf8f6c9f0ce
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list