[MERGED] osmo-bsc[master]: vty: fix 'show lchan ...' arg [lchan_nr] to [<0-7>]

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri Jan 19 22:09:29 UTC 2018


Harald Welte has submitted this change and it was merged.

Change subject: vty: fix 'show lchan ...' arg [lchan_nr] to [<0-7>]
......................................................................


vty: fix 'show lchan ...' arg [lchan_nr] to [<0-7>]

A lower-case argument is a keyword, not a variable placeholder. Hence the user
would not be able to pass a number, just the "lchan_nr" string itself, hence
this would never work.

Depending on pchan, lchans can range 0..7, so use that instead.

Change-Id: Ib9a0b43b68c4682cd6de24d01c0de421c9ce957a
---
M src/libbsc/bsc_vty.c
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/libbsc/bsc_vty.c b/src/libbsc/bsc_vty.c
index e60bdaf..dcdd28a 100644
--- a/src/libbsc/bsc_vty.c
+++ b/src/libbsc/bsc_vty.c
@@ -1297,7 +1297,7 @@
 
 DEFUN(show_lchan,
       show_lchan_cmd,
-      "show lchan [<0-255>] [<0-255>] [<0-7>] [lchan_nr]",
+      "show lchan [<0-255>] [<0-255>] [<0-7>] [<0-7>]",
 	SHOW_STR "Display information about a logical channel\n"
 	"BTS Number\n" "TRX Number\n" "Timeslot Number\n"
 	LCHAN_NR_STR)
@@ -1308,7 +1308,7 @@
 
 DEFUN(show_lchan_summary,
       show_lchan_summary_cmd,
-      "show lchan summary [<0-255>] [<0-255>] [<0-7>] [lchan_nr]",
+      "show lchan summary [<0-255>] [<0-255>] [<0-7>] [<0-7>]",
 	SHOW_STR "Display information about a logical channel\n"
         "Short summary\n"
 	"BTS Number\n" "TRX Number\n" "Timeslot Number\n"

-- 
To view, visit https://gerrit.osmocom.org/5930
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib9a0b43b68c4682cd6de24d01c0de421c9ce957a
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list