This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has submitted this change and it was merged. Change subject: Fix of checking TCH rate at chan_compat_with_mode ...................................................................... Fix of checking TCH rate at chan_compat_with_mode In case of current channel equals TCH/F and we request half rate, we must return 0, so the calling function will trigger assignment. Change-Id: Ibb4cb9aef1a1146f984d7c969bfba53c647cae07 --- M src/libbsc/bsc_api.c 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Vadim Yanitskiy: Looks good to me, but someone else must approve Harald Welte: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/libbsc/bsc_api.c b/src/libbsc/bsc_api.c index bd55dfc..3592c00 100644 --- a/src/libbsc/bsc_api.c +++ b/src/libbsc/bsc_api.c @@ -357,7 +357,11 @@ * an explicit override by the 'full_rate' argument */ switch (lchan->type) { case GSM_LCHAN_TCH_F: - return 1; + if (full_rate) + return 1; + else + return 0; + break; case GSM_LCHAN_TCH_H: if (full_rate) return 0; -- To view, visit https://gerrit.osmocom.org/5899 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibb4cb9aef1a1146f984d7c969bfba53c647cae07 Gerrit-PatchSet: 4 Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>