This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgPatch Set 2: Code-Review+1 (2 comments) https://gerrit.osmocom.org/#/c/5879/2//COMMIT_MSG Commit Message: Line 20: Change-Id: Iebc95043569191b6f5fbc8fe266b13fcfcab2e48 related: OS#2631 https://gerrit.osmocom.org/#/c/5879/2/src/libosmo-mgcp/mgcp_msg.c File src/libosmo-mgcp/mgcp_msg.c: Line 240: return find_free_endpoint(cfg->trunk.endpoints, the "find_endpoint" function should do prefix-matching on the endpoint class, and then call a class specific function pointer for further parsing. So here it would basically simply iterate over the list of registered endpoint classes and do a prefix match, and then dispatch into the respective function. Could be another patch, but it's starting to bother me that the basic architecture is still so wrong. -- To view, visit https://gerrit.osmocom.org/5879 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iebc95043569191b6f5fbc8fe266b13fcfcab2e48 Gerrit-PatchSet: 2 Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: Yes